Various fixes and improvements to hash2curve #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
hash2curve-improvement2
branch
from
3c73c3d to
5f3658c
Compare
daxpedda
force-pushed
the
hash2curve-improvement2
branch
from
5f3658c to
f0186fa
Compare
daxpedda
force-pushed
the
hash2curve-improvement2
branch
from
edc77d1 to
1f2fd8b
Compare
daxpedda
force-pushed
the
hash2curve-improvement2
branch
from
1f2fd8b to
2f0bf9b
Compare
mikelodder7
approved these changes
Apr 17, 2025
tarcieri
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mainly to fix a bug in handling large DSTs for
expand_message_xof.ExpandMsg::expand_message()slen_in_bytesparameter is now aNonZero, moving one run-time error to the type system.FromOkm::Lengthnow requirestypenum::NonZero.Kparameter toExpandMsgimplementers.ExpandMsgXmdonly uses it to follow constraints set by the specification more closely. See https://www.rfc-editor.org/rfc/rfc9380.html#section-5.3.1-2.1.ExpandMsgXof, requiresKto calculate the size for the computed DST if the given DST is larger than 255 bytes. This was previously not implemented correctly in that it always used a 32-byte long computed DST.type Kto theGroupDigesttrait. This allows blanket implementations to use the rightKforExpandMsgXmdandExpandMsgXof.HashMarkerto the constraints ofHashTforExpandMsgXof.ExpandMsgtrait implementations to the actual type and added links to the specification.Cc @mikelodder7.